-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the hashed name for the path to each ssh-secret. (eclipse#14151). #14243
Use the hashed name for the path to each ssh-secret. (eclipse#14151). #14243
Conversation
I'm testing it now on my Che instance. |
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
I checked this on my instance. It works well.
|
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
After inspecting code, I rethink my concern should be fixed by apply some patches to the |
Removing label |
@l0rd I see. IMO, It's better to add some more patches to this PR. I'll do it later. |
The DevFile error is gone when I merged master, but I see an error when starting a workspace If an SSH key with name
|
@vinokurig The issue with pasting the devfile is the |
Hello, @monaka! Do you have plan continue work on this PR? |
@vparfonov Thanks for the heads up. This PR is no longer required after #14950 applied. |
Signed-off-by: Masaki Muranaka monaka@monami-ya.com
What does this PR do?
Uses the hashed name for the path to each ssh-secret.
As I commented, the name for key-pair can be contain characters that is not fit for file path.
What issues does this PR fix or reference?
eclipse#14151 eclipse#14152 eclipse#14156